search

kubernetes-sigs / cluster-addons

Addon operators for Kubernetes clusters.
Apache License 2.0
155 stars 47 forks source link

rbac-gen: updates for status #114

Closed justinsb closed 2 years ago

justinsb commented 2 years ago

Add list & watch to the generated permissions (we already have get).

Also include permissions for querying the status subresource.

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-addons/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
atoato88 commented 2 years ago

Update codebase is OK for me, but CI test failed because convert logic is updated. It's need to update some golden tests, I think.

justinsb commented 2 years ago

I think the remaining failures are due to a change in behaviour of go get - sent #115 to (hopefully) fix

atoato88 commented 2 years ago

/retest

atoato88 commented 2 years ago

@justinsb I left comment, please check it.

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

atoato88 commented 2 years ago

Can anyone check and approve? I don't have approver role on this repo.

atoato88 commented 2 years ago

/lgtm I have not received some comments, but it's a small item, almost all items are OK. I think it's good to merge this. Sorry for my late decision.