search

kubernetes-sigs / cluster-addons

Addon operators for Kubernetes clusters.
Apache License 2.0
155 stars 47 forks source link

Update makefiles for go-get changes #115

Closed justinsb closed 2 years ago

justinsb commented 2 years ago

We are now seeing build errors on newer go versions, so update the Makefile to use the new method of downloading build tools.

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-addons/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
justinsb commented 2 years ago

116 confirms (I believe) that the go updates have broken the way we download binaries in older kubebuilder Makefiles.

justinsb commented 2 years ago

Thanks @atoato88 - updated to dashboard controller-gen 0.3.0 with your changes!

atoato88 commented 2 years ago

/lgtm

Now, all CI tests are pass, so we can merge this PR. And we can double check /retest on #116