search

kubernetes-sigs / cluster-addons

Addon operators for Kubernetes clusters.
Apache License 2.0
155 stars 47 forks source link

Operator for the Kubernetes dashboard #44

Closed somtochiama closed 4 years ago

somtochiama commented 4 years ago

This is a pull request to add an operator for the Kubernetes dashboard

atoato88 commented 4 years ago

@SomtochiAma Thank you for creating PR :smile: dashboard-operator exists at kubebuilder-declarative-pattern repo as a example of kubebuilder-declarative-pattern. Recently, we discussed about move dashboard-operator from kubebuilder-declarative-pattern repo to cluster-addons repo. So your PR is very good for me. Could you see kubebuilder-declarative-pattern repo and mix to your PR?

/cc @johnsonj

somtochiama commented 4 years ago

discussed

@SomtochiAma Thank you for creating PR 😄 dashboard-operator exists at kubebuilder-declarative-pattern repo as a example of kubebuilder-declarative-pattern. Recently, we discussed about move dashboard-operator from kubebuilder-declarative-pattern repo to cluster-addons repo. So your PR is very good for me. Could you see kubebuilder-declarative-pattern repo and mix to your PR?

/cc @johnsonj

Sure. I will do that.

atoato88 commented 4 years ago

@SomtochiAma IMHO, the difference of between your PR and dashboard-operator in kubebuilder-declarative-pattern is following.

@johnsonj Should we move the code of dashboard-operator in kubebuilder-declarative-pattern to cluster-addons first, and next, modify the code if any updates? WDYT?

atoato88 commented 4 years ago

Thank you to update! I have single comment.

atoato88 commented 4 years ago

Could you add tests?

  • dashboard-operator in kubebuilder-declarative-pattern has tests for operator at here
atoato88 commented 4 years ago

I've confirmed to pass a test. /lgtm

justinsb commented 4 years ago

Thanks @SomtochiAma , and thanks also to @atoato88 for working together to figure out the right way forwards.

Sounds like we have consensus, so...

/approve /lgtm

We can always iterate on it as well - I think I want to figure out what to do about the config/ directories which are the bulk of the repetitive boilerplate.

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, SomtochiAma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-addons/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment