search

kubernetes-sigs / cluster-addons

Addon operators for Kubernetes clusters.
Apache License 2.0
155 stars 47 forks source link

Move the framework for smoketests to a new test dir #63

Closed rajansandeep closed 4 years ago

rajansandeep commented 4 years ago

The smoketest file previously resided in the coredns operator directory.

Moving it outside to a new "test" folder while also adding a basic framework to the existing operators

dholbach commented 4 years ago

/uncc /cc @justinsb

justinsb commented 4 years ago

Thanks @rajansandeep ... will be wonderful to have more & better test coverage to keep us working with all the improvements being made here :-)

/approve /lgtm

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, rajansandeep

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-addons/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rajansandeep commented 4 years ago

@justinsb needs lgtm again due to rebase

atoato88 commented 4 years ago

/lgtm Thank you to update.