Closed somtochiama closed 4 years ago
This is an awesome first step!
I have lots of ideas on how to evolve this / make this faster, but it works as-is. (The biggest gotchas were the authn import, and the fact that you have to use the full kind). So I propose we merge this and evaluate whether it's as useful as we think it's going to be! Then if so, we can optimize it / tackle some of the nits.
/ok-to-test /approve /lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: justinsb, SomtochiAma
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Hi @SomtochiAma. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with
/ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.Once the patch is verified, the new status will be reflected by the
ok-to-test
label.I understand the commands that are listed here.