search

kubernetes-sigs / cluster-addons

Addon operators for Kubernetes clusters.
Apache License 2.0
155 stars 47 forks source link

Update the stable CoreDNS version to v1.7.0 #74

Closed rajansandeep closed 4 years ago

rajansandeep commented 4 years ago

Updates from v1.6.9 to v1.7.0 Also updates the corresponding migration library to support v1.7.0

dholbach commented 4 years ago

/uncc /cc @justinsb @johnsonj

justinsb commented 4 years ago

LGTM, but can we / should we keep 1.6.9 available?

rajansandeep commented 4 years ago

Currently, I've been adding the versions that are being released with upstream k8s (CoreDNS 1.7.0 will be shipped with 1.19 etc.), but I can certainly keep 1.6.9.

justinsb commented 4 years ago

Currently, I've been adding the versions that are being released with upstream k8s (CoreDNS 1.7.0 will be shipped with 1.19 etc.),

Ah - that's a reasonable strategy. If no version of k8s shipped with 1.6.9, then I don't think we need to keep it at this stage. nce we get everyone using the operator, then we should expect that some people will pin versions, and once we support a version we should not generally stop supporting it.

It's easy enough to add 1.6.9 back if we do need it, so approving :-)

/approve /lgtm

Thanks @rajansandeep :-)

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, rajansandeep

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-addons/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment