Generic controller

[k8s-ci-robot]

Hi @SomtochiAma. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

[dholbach]

/ok-to-test /uncc /cc @stealthybox

[justinsb]

This is looking really good! We do need the tools to generate the RBAC & the manifests, but then this is going to be a really nice experience for users!

[cmoulliard]

Can you please add a README.md file under the tools in order to explain how to use them with some concrete examples ?

[cmoulliard]

I got this error when I run the generic controller under a kind cluster using the command make deploy

kc logs generic-controller-manager-5d9cf5db7b-mnfc2 -n generic-system -c manager
2020-08-06T10:27:56.581Z    INFO    controller-runtime.metrics  metrics server is starting to listen    {"addr": "127.0.0.1:8080"}
Please create a `Generic` resource

Why should we do then deploy first a Generic CRD before to start the controler ?

[somtochiama]

I got this error when I run the generic controller under a kind cluster using the command make deploy

kc logs generic-controller-manager-5d9cf5db7b-mnfc2 -n generic-system -c manager
2020-08-06T10:27:56.581Z  INFO    controller-runtime.metrics  metrics server is starting to listen    {"addr": "127.0.0.1:8080"}
Please create a `Generic` resource

Why should we do then deploy first a Generic CRD before to start the controler ?

The generic controller is different because it is used as a general controller for other simple addons that don't require any extra configuration. The Generic resource is used to tell the generic controller these addons are and where to find their channels

[somtochiama]

Can you please add a README.md file under the tools in order to explain how to use them with some concrete examples ?

I will definitely do so

[cmoulliard]

The Generic resource is used to tell the generic controller these addons are and where to find their channels

Maybe then review the message logged to make it more explicit about root cause of the error and what is it needed to be done to avoid it. As the controller will crash, then we must find a way to make it healthy if a Generic CR has been deployed ...

[somtochiama]

Maybe then review the message logged to make it more explicit about root cause of the error and what is it needed to be done to avoid it.

I changed the message and added a REAME.md for the tools. Please review whenever you can! Thanks

[justinsb]

This is really cool and it sounds like people want to start trying it out, so let's merge it and iterate with further improvements!

/approve /lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, SomtochiAma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-addons/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment