search

kubernetes-sigs / cluster-addons

Addon operators for Kubernetes clusters.
Apache License 2.0
155 stars 47 forks source link

port kube-addon-manager v9.1.1 to Go as cluster-addons-bootstrap #76

Closed dekkagaijin closed 4 years ago

dekkagaijin commented 4 years ago

This is a re-homing of https://github.com/kubernetes/kubernetes/pull/92978

The course of action agreed upon during the sig-arch meeting was that addon-manager would be adopted by cluster-addons and used as a bootstrap mechanism.

I implemented this as a drop-in replacement for k/k's addon-manager, but we can improve things over time. For example, we may want to use the k8s client directly and/or use watches to improve performance. The immediate benefits are:

TODOs:

k8s-ci-robot commented 4 years ago

Welcome @dekkagaijin!

It looks like this is your first PR to kubernetes-sigs/cluster-addons 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-addons has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 4 years ago

Hi @dekkagaijin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dekkagaijin commented 4 years ago

/assign @justinsb /cc @dims @cheftako @MrHohn @spencer-p

k8s-ci-robot commented 4 years ago

@dekkagaijin: GitHub didn't allow me to request PR reviews from the following users: spencer-p.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/kubernetes-sigs/cluster-addons/pull/76#issuecomment-674600011): >/assign @justinsb >/cc @dims @cheftako @MrHohn @spencer-p Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
dekkagaijin commented 4 years ago

FYI I've been using the original k/k PR to e2e test this image

rajansandeep commented 4 years ago

/ok-to-test

dims commented 4 years ago

/approve /lgtm

justinsb commented 4 years ago

This looks great - I have some feedback, but nothing that I would consider blocking (and I see you already have some of them on your TODO list above!) So let's merge and iterate :-)

justinsb commented 4 years ago

/approve /lgtm

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dekkagaijin, dims, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-addons/blob/master/OWNERS)~~ [justinsb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment