kubernetes-sigs / cluster-api-addon-provider-helm

CAAPH uses Helm charts to manage the installation and lifecycle of Cluster API add-ons.
Apache License 2.0
121 stars 30 forks source link

Helm status doesn't update when underlying cluster status changes #196

Open dtzar opened 6 months ago

dtzar commented 6 months ago

What steps did you take and what happened:

  1. Deploy HelmChartProxy to cluster1 where cluster1 is not reachable
  2. Add another cluster2 where the same HelmChartProxy applies via using the same labels (this one does work)
  3. Change/delete the label for Cluster1 so that the HelmChartProxy no longer applies to that cluster
  4. The status of that HelmChartProxy still shows failure mode even though it no longer applies to that cluster

What did you expect to happen:

Status:
  Conditions:
    Last Transition Time:  2024-03-19T20:38:32Z
    Message:               Kubernetes cluster unreachable: Get "https://argocluster-azphsqsi.hcp.westus3.azmk8s.io:443/version": dial tcp: lookup argocluster-azphsqsi.hcp.westus3.azmk8s.io on 10.96.0.10:53: no such host    
    Reason:                HelmReleaseGetFailed @ HelmReleaseProxy/argo-cd-argocluster-rrf94
    Severity:              Error
    Status:                False
    Type:                  Ready
    Last Transition Time:  2024-03-19T20:38:32Z
    Message:               Kubernetes cluster unreachable: Get "https://argocluster-azphsqsi.hcp.westus3.azmk8s.io:443/version": dial tcp: lookup argocluster-azphsqsi.hcp.westus3.azmk8s.io on 10.96.0.10:53: no such host    
    Reason:                HelmReleaseGetFailed @ HelmReleaseProxy/argo-cd-argocluster-rrf94
    Severity:              Error
    Status:                False
    Type:                  HelmReleaseProxiesReady
    Last Transition Time:  2024-03-19T22:45:24Z
    Status:                True
    Type:                  HelmReleaseProxySpecsUpToDate
  Matching Clusters:
    API Version:        cluster.x-k8s.io/v1beta1
    Kind:               Cluster
    Name:               argoclustercaaph
    Namespace:          default
  Observed Generation:  9
Events:                 <none>

Environment:

/kind bug [One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels]

k8s-triage-robot commented 3 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

Jont828 commented 3 months ago

@dtzar I remember we spoke about this a while back. Is this an issue we can still repro, or was it a one-off failure?

Jont828 commented 3 months ago

/triage-accepted

k8s-triage-robot commented 2 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 1 month ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 1 month ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes-sigs/cluster-api-addon-provider-helm/issues/196#issuecomment-2308982824): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
dtzar commented 1 month ago

/reopen

k8s-ci-robot commented 1 month ago

@dtzar: Reopened this issue.

In response to [this](https://github.com/kubernetes-sigs/cluster-api-addon-provider-helm/issues/196#issuecomment-2311128481): >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-triage-robot commented 5 days ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 5 days ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes-sigs/cluster-api-addon-provider-helm/issues/196#issuecomment-2375295209): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
dtzar commented 4 days ago

/reopen

k8s-ci-robot commented 4 days ago

@dtzar: Reopened this issue.

In response to [this](https://github.com/kubernetes-sigs/cluster-api-addon-provider-helm/issues/196#issuecomment-2377338493): >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.