search

kubernetes-sigs / cluster-api-operator

Home for Cluster API Operator, a subproject of sig-cluster-lifecycle
https://cluster-api-operator.sigs.k8s.io
Apache License 2.0
146 stars 60 forks source link

🐛 Revert "don’t deliver cert-manager CRDs with cluster-api-operator chart" #515

Closed Fedosin closed 1 month ago

Fedosin commented 2 months ago

This reverts commit c8a9022ba90e00c259ef5a8c4ca6a69d69180ed4.

What this PR does / why we need it:

PR #453 broke installation of cert-manager CRDs, so we revert that regression.

The reason why cert-manager CRDs were placed in "crds" folder, is because in this case Helm applies them earlier, before all other manifests. Also Helm guarantees that if these CRDs are already presented in the system, it won't overwrite them.

If we template everything together, both cert-manager resources and CRDs will be applied simultaneously, and we get this error:

Error: INSTALLATION FAILED: unable to build kubernetes objects from release manifest: [resource mapping not found for name: "capi-operator-serving-cert" namespace: "capi-operator-system" from "": no matches for kind "Certificate" in version "cert-manager.io/v1" ensure CRDs are installed first, resource mapping not found for name: "capi-operator-selfsigned-issuer" namespace: "capi-operator-system" from "": no matches for kind "Issuer" in version "cert-manager.io/v1" ensure CRDs are installed first]

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from fedosin. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/cluster-api-operator/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
netlify[bot] commented 2 months ago

Deploy Preview for kubernetes-sigs-cluster-api-operator ready!

Name Link
Latest commit b4de99600d13ef8665345f909dce2919acb88f37
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-operator/deploys/6633a81c5897d900092c2f68
Deploy Preview https://deploy-preview-515--kubernetes-sigs-cluster-api-operator.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Fedosin commented 1 month ago

During the community meeting we decided to remove cert-manager support from the helm chart, because it is doesn't work with ArgoCD.