kubernetes-sigs / cluster-api-operator

Home for Cluster API Operator, a subproject of sig-cluster-lifecycle
https://cluster-api-operator.sigs.k8s.io
Apache License 2.0
162 stars 77 forks source link

Helm chart to support to override deployment for all providers #516

Open KannanThiru opened 5 months ago

KannanThiru commented 5 months ago

User Story

Unable to override ImageUrl to support private cloud when no route to external images

Detailed Description

Helm chart should have option to override imageurl and other features when needed across all providers.

Example output:

apiVersion: operator.cluster.x-k8s.io/v1alpha2
kind: InfrastructureProvider
metadata:
  name: vsphere
  namespace: vsphere-infrastructure-system
  annotations:
    "helm.sh/hook": "post-install"
    "helm.sh/hook-weight": "2"
spec:
  configSecret:
    name: vsphere-identity-secret
    namespace: default
  deployment:
    containers:
    - name: manager
      imageUrl: "test.org/cluster-api-vsphere/cluster-api-vsphere-controller:v1.10.0"

Adding support deployment on helm chart for each providers to helps better for private cloud.

Ex: infra.yaml

{{- if hasKey $.Values.deployment "infrastructure" }}
{{- range $key, $value := $.Values.deployment }}
  {{- if eq $key "infrastructure" }}
  deployment:
  {{- toYaml $value | nindent 4 }}
  {{- end }}
{{- end }}
{{- end }}

Ex: value.yaml file

deployment:
  core:
    containers:
    - name: manager
      imageUrl: "test.org/cluster-api/cluster-api-controller:v1.7.1"
  infrastructure:
    containers:
    - name: manager
      imageUrl: "test.org/cluster-api-vsphere/cluster-api-vsphere-controller:v1.10.0"

/kind feature

omerap12 commented 4 months ago

Ill take it /assign

k8s-triage-robot commented 1 month ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 3 weeks ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

furkatgofurov7 commented 1 week ago

/remove-lifecycle rotten /triage accepted