search

kubernetes-sigs / cluster-api-operator

Home for Cluster API Operator, a subproject of sig-cluster-lifecycle
https://cluster-api-operator.sigs.k8s.io
Apache License 2.0
146 stars 60 forks source link

⚠️ remove cert-manager support from helm chart #521

Closed Fedosin closed 1 month ago

Fedosin commented 1 month ago

What this PR does / why we need it: Right now we have experimental support for Cert Manager installation in the chart. As part of this, we store Cert Manager CRDs in the "crds" folder. If you install the chart with Helm, everything works fine, resources are only installed if they don't exist in the cluster. But if we use Argo, we always install CRDs even if they already exist by overwriting them. Since we can't get around this limitation, we decided to remove Cert Manager support from the chart.

We recommend using the clusterctl plugin for local development and testing that retains support for installing Cert Manager. In the case of the chart, users must manage Cert Manager installation themselves.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

netlify[bot] commented 1 month ago

Deploy Preview for kubernetes-sigs-cluster-api-operator ready!

Name Link
Latest commit 4123e888180afa2cbd3056591f78a8e9d88e56e0
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-operator/deploys/66420fc70f4f7800082df0da
Deploy Preview https://deploy-preview-521--kubernetes-sigs-cluster-api-operator.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Fedosin commented 1 month ago

/hold for further duscussions.

Fedosin commented 1 month ago

/hold cancel

alexander-demicev commented 1 month ago

/approve

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexander-demicev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-operator/blob/main/OWNERS)~~ [alexander-demicev] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Danil-Grigorev commented 1 month ago

/lgtm

k8s-ci-robot commented 1 month ago

LGTM label has been added.

Git tree hash: d012f90b50faf6ae1ff729c7d8f1b2574552e184