Open omerap12 opened 4 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign danil-grigorev for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Welcome @omerap12!
It looks like this is your first PR to kubernetes-sigs/cluster-api-operator 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/cluster-api-operator has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @omerap12. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Name | Link |
---|---|
Latest commit | 45d8d6b5a28528859dafc417c1e30ab2d8784378 |
Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-cluster-api-operator/deploys/66c8699b88f4e60008b81933 |
Deploy Preview | https://deploy-preview-525--kubernetes-sigs-cluster-api-operator.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
/ok-to-test
Of course, Ill try to do it on this weekend @alexander-demicev
Hey @alexander-demicev , any update on this? should I close the PR?
/retest
@omerap12 hey, thanks for the PR. Can you please rebase it first, so we can then take a closer look? Thanks
@omerap12 hey, thanks for the PR. Can you please rebase it first, so we can then take a closer look? Thanks
Done
/retest
@omerap12 hey, thanks for the PR. Can you please rebase it first, so we can then take a closer look? Thanks
Done
Looks like something went wrong with rebase, I see your branch is still behind by 32 commits. I was suspecting the rebase being the initial root cause of CI failure
@omerap12 hey, thanks for the PR. Can you please rebase it first, so we can then take a closer look? Thanks
Done
Looks like something went wrong with rebase, I see your branch is still behind by 32 commits. I was suspecting the rebase being the initial root cause of CI failure
Merged master
By checking the CI logs, e2e tests are not compiling properly
By checking the CI logs, e2e tests are not compiling properly
When I first submitted the PR they seemed to wok lol. Ill take a look later and get this fixed
@furkatgofurov7 Fixed :)
btw, can I set deploymentOverride in the values file to a default of empty dict?
deploymentOverride: {}
Hey, thanks. Can we also add tests for other provider types (currently, only infra provider is being added)?
Hey, thanks. Can we also add tests for other provider types (currently, only infra provider is being added)?
Added another test.
Please, let me rebase my changes when approved.
What this PR does / why we need it: Adding option to override certain configuration in the following resources: addon bootstrap control-plane core-conditions core infra-conditions infra
Example of values.yaml snippet:
Output be like:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged): Fixes #516