search

kubernetes-sigs / cluster-api-operator

Home for Cluster API Operator, a subproject of sig-cluster-lifecycle
https://cluster-api-operator.sigs.k8s.io
Apache License 2.0
146 stars 60 forks source link

🌱 Add more cases to helm test #549

Closed willie-yao closed 3 weeks ago

willie-yao commented 3 weeks ago

What this PR does / why we need it: This PR adds a few test cases that would've caught the issues found in #532. It also switches the yaml comparison from Equal to MatchYAML which prints a much more informative message for failures.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

netlify[bot] commented 3 weeks ago

Deploy Preview for kubernetes-sigs-cluster-api-operator ready!

Name Link
Latest commit 58d8e15fc6e974bf685edbf90c59182285325d9e
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-operator/deploys/666248a25036e300086249ff
Deploy Preview https://deploy-preview-549--kubernetes-sigs-cluster-api-operator.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

k8s-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexander-demicev, Fedosin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[test/OWNERS](https://github.com/kubernetes-sigs/cluster-api-operator/blob/main/test/OWNERS)~~ [Fedosin,alexander-demicev] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 3 weeks ago

LGTM label has been added.

Git tree hash: 2451edb4c4d728918feb9aa79e1ea7ab04257a32