search

kubernetes-sigs / cluster-api-operator

Home for Cluster API Operator, a subproject of sig-cluster-lifecycle
https://cluster-api-operator.sigs.k8s.io
Apache License 2.0
162 stars 77 forks source link

:bug: Fix infra Helm chart logic for additionalDeployments #583

Closed willie-yao closed 1 month ago

willie-yao commented 1 month ago

What this PR does / why we need it: This PR fixes a bug where the additionalDeployments field was bring printed incorrectly when using a values.yaml file. The recursivePrinter is not needed, and we can just use toYaml instead.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

netlify[bot] commented 1 month ago

Deploy Preview for kubernetes-sigs-cluster-api-operator ready!

Name Link
Latest commit 3aa4c741df6f40d373a55047ab822770298856a4
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-operator/deploys/66bbd07320f9dd0008a910c5
Deploy Preview https://deploy-preview-583--kubernetes-sigs-cluster-api-operator.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

k8s-ci-robot commented 1 month ago

LGTM label has been added.

Git tree hash: 120912f75f7529f35b669c325eb4d9814f1f86b5

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furkatgofurov7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-operator/blob/main/OWNERS)~~ [furkatgofurov7] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment