kubernetes-sigs / cluster-api-operator

Home for Cluster API Operator, a subproject of sig-cluster-lifecycle
https://cluster-api-operator.sigs.k8s.io
Apache License 2.0
167 stars 77 forks source link

Cannot start CAPI providers restricted to a namespace #624

Open serngawy opened 3 days ago

serngawy commented 3 days ago

What steps did you take and what happened: create infrastructure Provider ex; CAPA with setting the container manager args to include a namespace

apiVersion: operator.cluster.x-k8s.io/v1alpha2
kind: InfrastructureProvider
metadata:
  name: aws
  namespace: capa-system
spec:
  configSecret:
    name: capa-manager-bootstrap-credentials
    namespace: capa-system
  deployment:
    containers:
      - command:
          - /manager
        args:
          "--namespace": "capa-system"
        name: manager
  version: v2.6.1

What did you expect to happen: Expect to have the capa provider deployment args assigned with "--namespace"

Anything else you would like to add: Found the check for the provider args here ignoring the namespace as argument.

Environment:

/kind bug [One or more /area label. See https://github.com/kubernetes-sigs/cluster-api-operator/labels?q=area for the list of labels]

k8s-ci-robot commented 3 days ago

This issue is currently awaiting triage.

If CAPI Operator contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.