search

kubernetes-sigs / cluster-api-operator

Home for Cluster API Operator, a subproject of sig-cluster-lifecycle
https://cluster-api-operator.sigs.k8s.io
Apache License 2.0
174 stars 79 forks source link

Missing manager featureGates for Bootstrap and ControlPlane Providers #633

Open gcezaralmeida opened 2 weeks ago

gcezaralmeida commented 2 weeks ago

What steps did you take and what happened: It is missing the logic to add the manager.featureGates to the bootstrapProvider and controlplaneProvider in helm template files. In the latest release this can be done only for coreProvider and infraProvider.

E.g.

...
manager:
  featureGates:
    core:
       KubeadmBootstrapFormatIgnition: true 
     bootstrap:                                                     # This one is missing from the template
       KubeadmBootstrapFormatIgnition: true 
     controlplane:                                                 # This one is missing from the template
       KubeadmBootstrapFormatIgnition: true 
...

What did you expect to happen: Add those manager features gates to the provider Bootstrap and ControlPlane providers.

Anything else you would like to add: I want to contribute to this fix. I will create a PR for this.

Environment:

/kind bug [One or more /area label. See https://github.com/kubernetes-sigs/cluster-api-operator/labels?q=area for the list of labels]

furkatgofurov7 commented 2 weeks ago

/triage accepted @gcezaralmeida feel free to assign this and tag me once you open a PR, thanks!