search

kubernetes-sigs / cluster-api-provider-aws

Kubernetes Cluster API Provider AWS provides consistent deployment and day 2 operations of "self-managed" and EKS Kubernetes clusters on AWS.
http://cluster-api-aws.sigs.k8s.io/
Apache License 2.0
633 stars 559 forks source link

Upgrade to use AWS SDK for Go v2 #2225

Open richardcase opened 3 years ago

richardcase commented 3 years ago

/kind feature

Describe the solution you'd like Now that the AWS SDK for Go version 2 is GA we should consider using it in CAPA. It brings a number of benefits including individual service modules and less use of pointers.

There are some things we need to be aware of that will complicate the change:

Environment:

richardcase commented 3 years ago

/assign

richardcase commented 3 years ago

/milestone Next

richardcase commented 3 years ago

/unassign

fejta-bot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale

richardcase commented 3 years ago

/lifecycle frozen

randomvariable commented 3 years ago

/lifecycle active /assign

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

richardcase commented 2 years ago

/lifecycle frozen

sedefsavas commented 2 years ago

/unassign @randomvariable Anyone interested in doing this can ask @randomvariable for help. /priority important-soon

Ankitasw commented 2 years ago

/assign

Ankitasw commented 2 years ago

/unassign for now based on the priority

richardcase commented 2 years ago

This is a really helpful write up that will be useful:

https://github.com/weaveworks/eksctl/issues/3215

sedefsavas commented 2 years ago

Thanks @richardcase One concern was the missing interfaces. In that issue, there are some good options to work around that.

@pydctw mentioned KOPS still uses AWS SDK v1 and ACK also uses that version.

We should consider what we are missing by delaying this move. If it will be the same amount of work, we could wait and see how other major repositories move to v2.

richardcase commented 2 years ago

/remove-lifecycle frozen

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 1 year ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-aws/issues/2225#issuecomment-1345348758): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
richardcase commented 1 year ago

/reopen /priority important-longterm /triage accepted

k8s-ci-robot commented 1 year ago

@richardcase: Reopened this issue.

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-aws/issues/2225#issuecomment-1514436222): >/reopen >/priority important-longterm >/triage accepted Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
richardcase commented 1 year ago

Sadly not :(

Skarlso commented 1 year ago

Yah I realised. :D Sorry. I was thinking about another project hahahaha.

k8s-triage-robot commented 1 year ago

This issue is labeled with priority/important-soon but has not been updated in over 90 days, and should be re-triaged. Important-soon issues must be staffed and worked on either currently, or very soon, ideally in time for the next release.

You can:

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

richardcase commented 7 months ago

/triage accepted

richardcase commented 7 months ago

We need to pick this up again as AWS have announced the v1 SDK will go into maintenance mode July 2024 and completely out of support July 2025.

https://aws.amazon.com/blogs/developer/announcing-end-of-support-for-aws-sdk-for-go-v1-on-july-31-2025/

k8s-triage-robot commented 4 months ago

This issue is labeled with priority/important-soon but has not been updated in over 90 days, and should be re-triaged. Important-soon issues must be staffed and worked on either currently, or very soon, ideally in time for the next release.

You can:

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

richardcase commented 4 months ago

/triage accepted /priority important-soon /help

k8s-ci-robot commented 4 months ago

@richardcase: This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-aws/issues/2225): >/triage accepted >/priority important-soon >/help Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-triage-robot commented 1 month ago

This issue is labeled with priority/important-soon but has not been updated in over 90 days, and should be re-triaged. Important-soon issues must be staffed and worked on either currently, or very soon, ideally in time for the next release.

You can:

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

richardcase commented 1 month ago

/priority important-soon /triage accepted

richardcase commented 1 month ago

/remove-lifecycle rotten

richardcase commented 1 month ago

@mjlshen - pinging you here in case you want to pick this up?

mjlshen commented 1 month ago

Ah yes, sure! Didn't realize there was already another issue. Slowly wading my way through understanding how clients/loggers interact through the various scopes currently.

/assign

richardcase commented 1 month ago

Another useful link (thanks @dims): https://aws.github.io/aws-sdk-go-v2/docs/migrating/