search

kubernetes-sigs / cluster-api-provider-aws

Kubernetes Cluster API Provider AWS provides consistent deployment and day 2 operations of "self-managed" and EKS Kubernetes clusters on AWS.
http://cluster-api-aws.sigs.k8s.io/
Apache License 2.0
646 stars 575 forks source link

Replace GNU Make with Go #2610

Closed randomvariable closed 2 years ago

randomvariable commented 3 years ago

/kind feature

Describe the solution you'd like [A clear and concise description of what you want to happen.]

This project originally started using Bazel, but the complexity grew and as Go introduced build caching, we replaced with Make. Unfortunately, the Makefile itself has become unwieldy, and not many folk either do or want to spend time writing M4, so we should look for a replacement. https://github.com/magefile/mage seems the most promising, allowing us to write the whole thing in Go.

Anything else you would like to add: [Miscellaneous information that will assist in solving the issue.]

We should scope out requirements before ploughing through with this. Feel free to reach out on Slack at https://kubernetes.slack.com/archives/CD6U2V71N

Environment:

randomvariable commented 3 years ago

/area release /priority important-longterm

k8s-triage-robot commented 3 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 3 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

richardcase commented 3 years ago

/priority backlog /triage accepted

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot commented 2 years ago

@k8s-triage-robot: Closing this issue.

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-aws/issues/2610#issuecomment-1002746500): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues and PRs according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue or PR with `/reopen` >- Mark this issue or PR as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
sedefsavas commented 2 years ago

/lifecycle stale

k8s-ci-robot commented 2 years ago

@randomvariable: This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
richardcase commented 2 years ago

@sedefsavas - we should probably discuss this one in office hours. I am not sure if there is any benefit moving away from a "standard"

richardcase commented 2 years ago

Discussed in the office hours call on 2022-01-10 and the consensus was that there should be significant improvments to switching to overcome the cost of switching from make to something else. We should improve the make experience and fix any issues that people have with it.

sedefsavas commented 2 years ago

We can create new issues if there are areas we should improve in the Makefile as this issue will not be closely relevant. Closing the issue as per Richard's explanation.