Ability to specify Availability Zones from the `VPCSpec` object

synthe102 commented 1 year ago

/kind feature

Describe the solution you'd like

Currently the AZ selection can be done using availabilityZoneUsageLimit and availabilityZoneSelection. However, there is no direct way to provide a list of availability zones to use. I'd like a field that takes a list of availability zone names (or zone IDs) and create the VPC and subnets only in those availability zones.

Environment:

Cluster-api-provider-aws version: 2.1.4
Kubernetes version: (use kubectl version):
OS (e.g. from /etc/os-release):

Ankitasw commented 1 year ago

/triage accepted

synthe102 commented 1 year ago

/milestone v2.3.0

k8s-ci-robot commented 1 year ago

@synthe102: You must be a member of the kubernetes-sigs/cluster-api-provider-aws-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Cluster API Provider AWS Maintainers and have them propose you as an additional delegate for this responsibility.

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-aws/issues/4333#issuecomment-1629371157): >/milestone v2.3.0 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

richardcase commented 1 year ago

/milestone v2.3.0 /help /priority important-soon

k8s-ci-robot commented 1 year ago

@richardcase: This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

Why are we solving this issue?
To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
Does this issue have zero to low barrier of entry?
How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-aws/issues/4333): >/milestone v2.3.0 >/help >/priority important-soon Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

Skarlso commented 1 year ago

/assign

Skarlso commented 1 year ago

Since availability zones are per region, defining a list of availability zones might not work in some of the regions.

Question... @synthe102 Would you expect the two settings of confinement ( AvailabilityZoneUsageLimit, AvailabilityZoneSelection ) to still work, or for them to be completely ignored if the list if defined ( thereby accepting the consequences that things might start to fail ).

Skarlso commented 1 year ago

I'm going to assume for now that ignoring the other two if this one is set, is okay and the user accepts the consequences.

synthe102 commented 1 year ago

@Skarlso it makes sense for me to ignore those and make the user assume the consequences

k8s-triage-robot commented 9 months ago

This issue is labeled with priority/important-soon but has not been updated in over 90 days, and should be re-triaged. Important-soon issues must be staffed and worked on either currently, or very soon, ideally in time for the next release.

You can:

Confirm that this issue is still relevant with /triage accepted (org members only)
Deprioritize it with /priority important-longterm or /priority backlog
Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

richardcase commented 9 months ago

/milestone v2.4.0

AndiDog commented 3 months ago

/triage accepted

sentinelleader commented 1 month ago

@Skarlso @AndiDog im also interested in this feature and the PR seems to be long open. Anything pending on the PR ?

kubernetes-sigs / cluster-api-provider-aws

Ability to specify Availability Zones from the `VPCSpec` object #4333

Guidelines