kubernetes-sigs / cluster-api-provider-aws

Kubernetes Cluster API Provider AWS provides consistent deployment and day 2 operations of "self-managed" and EKS Kubernetes clusters on AWS.
http://cluster-api-aws.sigs.k8s.io/
Apache License 2.0
643 stars 569 forks source link

Allow empty AMI ID, Instance type in launch template of AWSManagedMachinePool #4377

Open Julian-Chu opened 1 year ago

Julian-Chu commented 1 year ago

/kind feature

We try to adopt CAPI+CAPA for our cluster to have same configuration, but find something not supported in the launch template.

Describe the solution you'd like

In the AWSManagedMachinePool spec

Customizing managed nodes with launch templates

this is a launch template in our running EKS node group, we use to customize the security group and storage

Screenshot 2023-07-05 at 18 58 09

Anything else you would like to add:

Environment:

richardcase commented 1 year ago

/triage accepted /priority important-soon

richardcase commented 1 year ago

/milestone v2.3.0

AndiDog commented 11 months ago

/milestone v2.4.0

to match the delayed PR https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/4388

k8s-ci-robot commented 11 months ago

@AndiDog: You must be a member of the kubernetes-sigs/cluster-api-provider-aws-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Cluster API Provider AWS Maintainers and have them propose you as an additional delegate for this responsibility.

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-aws/issues/4377#issuecomment-1814489599): >/milestone v2.4.0 > >to match the delayed PR https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/4388 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
richardcase commented 11 months ago

/milestone v2.4.0

k8s-triage-robot commented 6 months ago

This issue is labeled with priority/important-soon but has not been updated in over 90 days, and should be re-triaged. Important-soon issues must be staffed and worked on either currently, or very soon, ideally in time for the next release.

You can:

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

k8s-triage-robot commented 3 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 2 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten