kubernetes-sigs / cluster-api-provider-aws

Kubernetes Cluster API Provider AWS provides consistent deployment and day 2 operations of "self-managed" and EKS Kubernetes clusters on AWS.
http://cluster-api-aws.sigs.k8s.io/
Apache License 2.0
633 stars 559 forks source link

Graduate the garbage Collection feature #4397

Open richardcase opened 1 year ago

richardcase commented 1 year ago

/kind feature

Describe the solution you'd like We introduced GC in v1.5.0 in Aug 2022. I propose that we graduate this feature and enable it by default.

Anything else you would like to add: [Miscellaneous information that will assist in solving the issue.]

Environment:

richardcase commented 1 year ago

/assign

richardcase commented 1 year ago

/milestone v2.3.0

richardcase commented 1 year ago

/triage accepted

richardcase commented 1 year ago

/priority important-soon

Ankitasw commented 1 year ago

@richardcase do we have a task list to track what all fixes should go as part of this?

Fedosin commented 1 year ago

@Ankitasw I think the remaining tasks are:

  1. Add validation for GC config (https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/4485)
  2. Add awscli support for GC configuration.
  3. Update the docs.

Tell me if I missed something.

richardcase commented 9 months ago

/milestone v2.4.0

Ankitasw commented 8 months ago

@Ankitasw I think the remaining tasks are:

Add validation for GC config (https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/4485) Add awscli support for GC configuration. Update the docs. Tell me if I missed something.

@Fedosin would you be able to proceed with these tasks?

richardcase commented 7 months ago

/unassign

richardcase commented 7 months ago

/help

k8s-ci-robot commented 7 months ago

@richardcase: This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-aws/issues/4397): >/help Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-triage-robot commented 4 months ago

This issue is labeled with priority/important-soon but has not been updated in over 90 days, and should be re-triaged. Important-soon issues must be staffed and worked on either currently, or very soon, ideally in time for the next release.

You can:

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

richardcase commented 4 months ago

/triage accepted /priority important-soon

richardcase commented 4 months ago

/milestone v2.5.0

richardcase commented 4 months ago

/assign /lifecycle active

k8s-triage-robot commented 1 month ago

This issue is labeled with priority/important-soon but has not been updated in over 90 days, and should be re-triaged. Important-soon issues must be staffed and worked on either currently, or very soon, ideally in time for the next release.

You can:

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

richardcase commented 1 month ago

/triage accepted