Closed alexander-demicev closed 4 months ago
/test pull-cluster-api-provider-aws-e2e /test pull-cluster-api-provider-aws-e2e-blocking /test pull-cluster-api-provider-aws-e2e-clusterclass /test pull-cluster-api-provider-aws-e2e-conformance /test pull-cluster-api-provider-aws-e2e-eks
/retest
/approve /hold
/assign @damdo
Holding for CI and second review.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: nrb
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/test pull-cluster-api-provider-aws-e2e-eks
/unhold
What type of PR is this? /kind bug
What this PR does / why we need it:
Ingress rules for the CP load balancer need to be processed like rules for CP instances. When user only specifies a source security group role, the controller should assign a proper ID to the ingress rule so it's gets assigned properly.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged): Fixes #Special notes for your reviewer:
Checklist:
Release note: