kubernetes-sigs / cluster-api-provider-aws

Kubernetes Cluster API Provider AWS provides consistent deployment and day 2 operations of "self-managed" and EKS Kubernetes clusters on AWS.
http://cluster-api-aws.sigs.k8s.io/
Apache License 2.0
636 stars 561 forks source link

🐛Apply the same set of rules for processing all custom ingress rules #4991

Closed alexander-demicev closed 4 months ago

alexander-demicev commented 4 months ago

What type of PR is this? /kind bug

What this PR does / why we need it:

Ingress rules for the CP load balancer need to be processed like rules for CP instances. When user only specifies a source security group role, the controller should assign a proper ID to the ingress rule so it's gets assigned properly.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Checklist:

Release note:

Apply the same set of rules for processing all custom ingress rules
nrb commented 4 months ago

/test pull-cluster-api-provider-aws-e2e /test pull-cluster-api-provider-aws-e2e-blocking /test pull-cluster-api-provider-aws-e2e-clusterclass /test pull-cluster-api-provider-aws-e2e-conformance /test pull-cluster-api-provider-aws-e2e-eks

nrb commented 4 months ago

/retest

/approve /hold

/assign @damdo

Holding for CI and second review.

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nrb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/main/OWNERS)~~ [nrb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
alexander-demicev commented 4 months ago

/test pull-cluster-api-provider-aws-e2e-eks

damdo commented 4 months ago

/unhold