search

kubernetes-sigs / cluster-api-provider-aws

Kubernetes Cluster API Provider AWS provides consistent deployment and day 2 operations of "self-managed" and EKS Kubernetes clusters on AWS.
http://cluster-api-aws.sigs.k8s.io/
Apache License 2.0
636 stars 561 forks source link

🐛 ROSA: Fix autoRepair default value #4994

Closed serngawy closed 4 months ago

serngawy commented 4 months ago

What type of PR is this? /kind bug

What this PR does / why we need it: The PR change the machinePool.AutoRepair default value to true as the default value of nodePool.AutoRepair at the OCM API here is true.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Checklist:

Release note:

Changing the ROSAMachienPool AutoRepair default value to true.
k8s-ci-robot commented 4 months ago

Hi @serngawy. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
cblecker commented 4 months ago

/ok-to-test

muraee commented 4 months ago

/lgtm please update the release notes to indicate the behavior change

nrb commented 4 months ago

Will approve once there's a release note.

serngawy commented 4 months ago

just to clarify, where is the release note should be added ?

damdo commented 4 months ago

@serngawy In this pull request description, where you typed None

nrb commented 4 months ago

/approve

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nrb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[config/crd/bases/OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/main/config/crd/bases/OWNERS)~~ [nrb] - ~~[exp/api/v1beta2/OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/main/exp/api/v1beta2/OWNERS)~~ [nrb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
damdo commented 3 months ago

/milestone v2.6.0

k8s-ci-robot commented 3 months ago

@damdo: You must be a member of the kubernetes-sigs/cluster-api-provider-aws-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Cluster API Provider AWS Maintainers and have them propose you as an additional delegate for this responsibility.

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/4994#issuecomment-2167520670): > >/milestone v2.6.0 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.