🌱 Bump setup-envtest to use new controller-tools binaries

kubernetes-sigs / cluster-api-provider-aws

Kubernetes Cluster API Provider AWS provides consistent deployment and day 2 operations of "self-managed" and EKS Kubernetes clusters on AWS.

http://cluster-api-aws.sigs.k8s.io/

Apache License 2.0

636 stars 561 forks source link

🌱 Bump setup-envtest to use new controller-tools binaries #4996

Closed damdo closed 3 months ago

damdo commented 4 months ago

What type of PR is this? /kind cleanup

What this PR does / why we need it: This was brought up in the weekly CAPI community meeting.

This is a commit from CR main (22.05.2024). Intentionally using a commit from main to use a setup-envtest version that uses binaries from controller-tools, not GCS. CR PR: https://github.com/kubernetes-sigs/controller-runtime/pull/2811

Release note:

NONE

TODO:

[x] Bump hack/tools too once this is addressed: https://github.com/kubernetes-sigs/controller-runtime/pull/2837#issuecomment-2139918231

damdo commented 4 months ago

/hold Until WIP

damdo commented 4 months ago

/unhold

/assign @nrb

damdo commented 4 months ago

@nrb should be ready for labelling.

nrb commented 3 months ago

/lgtm /approve

k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nrb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/main/OWNERS)~~ [nrb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

nrb commented 3 months ago

/retest