kubernetes-sigs / cluster-api-provider-aws

Kubernetes Cluster API Provider AWS provides consistent deployment and day 2 operations of "self-managed" and EKS Kubernetes clusters on AWS.
http://cluster-api-aws.sigs.k8s.io/
Apache License 2.0
626 stars 542 forks source link

✨ ROSA: Add upgrade config to ROSAMachinePool #4998

Closed serngawy closed 3 weeks ago

serngawy commented 1 month ago

What type of PR is this? /kind feature

What this PR does / why we need it: Add update configuration to ROSAMachinePool APIs.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Checklist:

Release note:

Add UpdateConfig to ROSAMachinePool APIs.
k8s-ci-robot commented 1 month ago

Hi @serngawy. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
serngawy commented 1 month ago

/cc @muraee

muraee commented 1 month ago

please also update nodePoolToRosaMachinePoolSpec() function https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/b99443a6c79f0a03543b5ce38bab2fbf471c9373/exp/controllers/rosamachinepool_controller.go#L483

serngawy commented 4 weeks ago

@damdo would you approve this PR for test

muraee commented 4 weeks ago

/ok-to-test

muraee commented 3 weeks ago

/lgtm

dlipovetsky commented 3 weeks ago

This adds some API fields.

/area api

k8s-ci-robot commented 3 weeks ago

@dlipovetsky: The label(s) kind/area/api cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/4998#issuecomment-2158805744): >This adds some API fields. > >/kind area/api Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
dlipovetsky commented 3 weeks ago

/area api

dlipovetsky commented 3 weeks ago

/assign

dlipovetsky commented 3 weeks ago

/approve

k8s-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlipovetsky

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/main/OWNERS)~~ [dlipovetsky] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
muraee commented 3 weeks ago

/area provider/rosa