kubernetes-sigs / cluster-api-provider-aws

Kubernetes Cluster API Provider AWS provides consistent deployment and day 2 operations of "self-managed" and EKS Kubernetes clusters on AWS.
http://cluster-api-aws.sigs.k8s.io/
Apache License 2.0
626 stars 542 forks source link

✨ Add natgatewayips as source for ingress rules #5005

Closed alexander-demicev closed 1 week ago

alexander-demicev commented 3 weeks ago

What type of PR is this? /kind feature

What this PR does / why we need it: This PR will allow using nat gateway IPs as sources in ingress rules. In my setup, I need machines to be able to connect to the load balancer through a certain port and I would like the load balancer to only accept traffic for this port from my machines. From the load balancer point of view the connection is made from nat gateway IPs so the CAPA API has to have a setting for this.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Checklist:

Release note:

Add natgatewayips as source for ingress rules
alexander-demicev commented 3 weeks ago

/test pull-cluster-api-provider-aws-e2e /test pull-cluster-api-provider-aws-e2e-eks

alexander-demicev commented 3 weeks ago

/test pull-cluster-api-provider-aws-e2e

alexander-demicev commented 3 weeks ago

/test pull-cluster-api-provider-aws-e2e

alexander-demicev commented 3 weeks ago

@nrb @damdo folks, can I get a review? all tests are passing

nrb commented 3 weeks ago

/milestone v2.6.0

k8s-ci-robot commented 3 weeks ago

@nrb: You must be a member of the kubernetes-sigs/cluster-api-provider-aws-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Cluster API Provider AWS Maintainers and have them propose you as an additional delegate for this responsibility.

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/5005#issuecomment-2159281806): >/milestone v2.6.0 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
nrb commented 3 weeks ago

/approve

k8s-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nrb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/main/OWNERS)~~ [nrb] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
salasberryfin commented 1 week ago

/lgtm thanks for adding this useful feature.