Closed alexander-demicev closed 1 week ago
/test pull-cluster-api-provider-aws-e2e /test pull-cluster-api-provider-aws-e2e-eks
/test pull-cluster-api-provider-aws-e2e
/test pull-cluster-api-provider-aws-e2e
@nrb @damdo folks, can I get a review? all tests are passing
/milestone v2.6.0
@nrb: You must be a member of the kubernetes-sigs/cluster-api-provider-aws-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Cluster API Provider AWS Maintainers and have them propose you as an additional delegate for this responsibility.
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: nrb
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/lgtm thanks for adding this useful feature.
What type of PR is this? /kind feature
What this PR does / why we need it: This PR will allow using nat gateway IPs as sources in ingress rules. In my setup, I need machines to be able to connect to the load balancer through a certain port and I would like the load balancer to only accept traffic for this port from my machines. From the load balancer point of view the connection is made from nat gateway IPs so the CAPA API has to have a setting for this.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged): Fixes #Special notes for your reviewer:
Checklist:
Release note: