search

kubernetes-sigs / cluster-api-provider-aws

Kubernetes Cluster API Provider AWS provides consistent deployment and day 2 operations of "self-managed" and EKS Kubernetes clusters on AWS.
http://cluster-api-aws.sigs.k8s.io/
Apache License 2.0
636 stars 561 forks source link

[release-2.5] 🐛 ROSA: fix ROSAMachinePool changes detection logic #5025

Closed k8s-infra-cherrypick-robot closed 3 months ago

k8s-infra-cherrypick-robot commented 3 months ago

This is an automated cherry-pick of #4977

/assign muraee

Fix ROSAMachinePool changes detection logic
damdo commented 3 months ago

/test ?

k8s-ci-robot commented 3 months ago

@damdo: The following commands are available to trigger required jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/5025#issuecomment-2167663436): >/test ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
muraee commented 3 months ago

/lgtm

muraee commented 3 months ago

/approve

k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: muraee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[exp/controllers/OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/release-2.5/exp/controllers/OWNERS)~~ [muraee] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment