Not all created resources are tagged

kubernetes-sigs / cluster-api-provider-aws

Kubernetes Cluster API Provider AWS provides consistent deployment and day 2 operations of "self-managed" and EKS Kubernetes clusters on AWS.

http://cluster-api-aws.sigs.k8s.io/

Apache License 2.0

637 stars 561 forks source link

Not all created resources are tagged #5043

Open UryDanko opened 3 months ago

UryDanko commented 3 months ago

/kind bug

What steps did you take and what happened:

I created a cluster with a node pool and a few nodes in it by using AWSManagedMachinePool and MachinePool. Also I set additionalTags with some tags in it.

What did you expect to happen: I'd expect that all created resources would have the same set of tags. However, some of them are tagged with the additionalTags, and some are not. For example: tagged: Node Pool IAM role attached to a node (EC2 instance) ASG backed the node pool

not tagged: node (EC2 instance) launch template, attached to the ASG SG attached to the EC2 EBS volume attached to EC2 (it has no tags at all)

Anything else you would like to add: Resources, mentioned above usually are tagged but some of them don't have additionalTags

Environment:

Cluster-api-provider-aws version: 2.5.2
Kubernetes version: (use kubectl version): 1.29
Cluster-api-operator version: 0.11.0

k8s-ci-robot commented 3 months ago

This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

k8s-triage-robot commented 2 weeks ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue as fresh with /remove-lifecycle stale
Close this issue with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

UryDanko commented 2 weeks ago

/remove-lifecycle stale