search

kubernetes-sigs / cluster-api-provider-azure

Cluster API implementation for Microsoft Azure
https://capz.sigs.k8s.io/
Apache License 2.0
296 stars 427 forks source link

Support autoscaling on self-managed MachinePool using MachinePool Machines #2328

Closed lzhecheng closed 11 months ago

lzhecheng commented 2 years ago

/kind feature

Describe the solution you'd like [A clear and concise description of what you want to happen.] Now autoscaling is supported only for managed clusters (aks). And regular clusters should be supported as well. Issue for managed one: https://github.com/kubernetes-sigs/cluster-api-provider-azure/issues/1669

I am add autoscaling CI for cloud-provider-azure with CAPZ. The original job defined with aks-engine: https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/cloud-provider-azure/cloud-provider-azure-config.yaml#L422-L483 The current cluster template: https://raw.githubusercontent.com/kubernetes-sigs/cloud-provider-azure/master/tests/k8s-azure/manifest/linux-autoscaler.json

Config is:

"pools": [
    {
        "name": "agentpool1",
        "config": {
            "min-nodes": "1",
            "max-nodes": "1000"
        }
    }
],
"config": {
    "scale-down-delay-after-add": "5m",
    "scale-down-unneeded-time": "5m"
}

related: https://github.com/kubernetes-sigs/cloud-provider-azure/issues/919

Anything else you would like to add: [Miscellaneous information that will assist in solving the issue.]

Environment:

lzhecheng commented 2 years ago

/cc @jackfrancis @feiskyer

CecileRobertMichon commented 2 years ago

/assign @mboersma

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 1 year ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-azure/issues/2328#issuecomment-1397755656): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
CecileRobertMichon commented 1 year ago

/remove-lifecycle rotten /lifecycle active /assign @Jont828 /reopen

cc @dtzar

k8s-ci-robot commented 1 year ago

@CecileRobertMichon: Reopened this issue.

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-azure/issues/2328#issuecomment-1397760634): >/remove-lifecycle rotten >/lifecycle active >/assign @Jont828 >/reopen > >cc @dtzar Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

Jont828 commented 1 year ago

/retitle Support autoscaling on self-managed MachinePool using MachinePool Machines

Jont828 commented 11 months ago

This should be done since #3998 is merged, closing this issue out.