Shorten AKS Windows pool names when AzureManagedMachinePool name is too long

[jackfrancis]

/kind feature

Describe the solution you'd like [A clear and concise description of what you want to happen.]

The AKS API enforces a max 6 character limit for node pool names. Because this is not necessarily an intuitive requirement, let's consider ways to do this automatically on behalf of users.

Anything else you would like to add: [Miscellaneous information that will assist in solving the issue.]

A possible approach to follow is https://github.com/kubernetes-sigs/cluster-api-provider-azure/pull/1408

Environment:

• cluster-api-provider-azure version:
• Kubernetes version: (use kubectl version):
• OS (e.g. from /etc/os-release):

[CecileRobertMichon]

/area managedcluster /help /good-first-issue

[k8s-ci-robot]

@CecileRobertMichon: This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-azure/issues/2422): >/area managedcluster >/help >/good-first-issue Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

[k8s-ci-robot]

@CecileRobertMichon: The label(s) area/managedcluster cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-azure/issues/2422#issuecomment-1177931569): >/area managedcluster >/help >/good-first-issue Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

[luthermonson]

@jackfrancis @CecileRobertMichon i think this covers it: https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/main/exp/api/v1beta1/azuremanagedmachinepool_webhook.go#L290-L301

[CecileRobertMichon]

indeed!

/close

[k8s-ci-robot]

@CecileRobertMichon: Closing this issue.

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-azure/issues/2422#issuecomment-1178262315): >indeed! > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

[jackfrancis]

So actually the foo that @luthermonson links to is validation that the user-configured pool name is no longer than 6 characters. I originally opened up this issue to track consideration of doing this automatically (truncating).

If we want to consider doing that (user inputs "my-pool-name-win" and we truncate to "win-kX" or something) we can re-open this issue.

[CecileRobertMichon]

Ah, understood. The title makes it sound like this is about validation I think.

/reopen /retitle Shorten AKS Windows pool names when AzureManagedMachinePool name is too long

[k8s-ci-robot]

@CecileRobertMichon: Reopened this issue.

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-azure/issues/2422#issuecomment-1179211580): >Ah, understood. The title makes it sound like this is about validation I think. > >/reopen >/retitle Shorten AKS Windows pool names when AzureManagedMachinePool name is too long Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

[sayantani11]

@jackfrancis @CecileRobertMichon I would like to get some more insight on this issue if possible!

[jackfrancis]

I'm not actually convinced we want to do this. @luthermonson do you have thoughts? Would you prefer a capz-enforced string concatenation and/or 6-char hash that replaces the inputted node pool name, or would you prefer capz to fail validation and force the user to purposefully choose a name that is 6 chars or fewer?

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale