kubernetes-sigs / cluster-api-provider-azure

Cluster API implementation for Microsoft Azure
https://capz.sigs.k8s.io/
Apache License 2.0
291 stars 421 forks source link

Add race detector toggle for Tilt binaries #2727

Open mboersma opened 1 year ago

mboersma commented 1 year ago

/kind feature

Describe the solution you'd like

From Go's documentation for the data race detector:

...you may find more races by running a binary built with -race under a realistic workload.

Let's add a RACE_DETECTOR option for Tilt to build binaries with the -race flag. This option may help us to find previously undetected bugs that will undoubtedly arise in production environments otherwise.

Anything else you would like to add:

To work on this issue, you should have a local development environment with tilt set up as described in CAPZ's developer documentation.

Implementing this begins with the Tiltfile in the root of the project, where you can identify each place we go build a binary. Add an option that will be read from your local tilt-settings.json, and amend each go build to include the -race flag if the option is enabled. (Or something like that. 😄)

Please ask for help here on this GitHub issue or in the cluster-api-azure Slack channel.

See also #2646

mboersma commented 1 year ago

/help /good-first-issue /priority backlog

k8s-ci-robot commented 1 year ago

@mboersma: This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-azure/issues/2727): >/help >/good-first-issue >/priority backlog > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
meghanajangi commented 1 year ago

/assign

k8s-triage-robot commented 1 year ago

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

mboersma commented 1 year ago

/unassign

SD-13 commented 11 months ago

/assign