Open nojnhuh opened 9 months ago
/milestone v1.14
/milestone next
The Kubernetes project currently lacks enough contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the issue is closedYou can:
/remove-lifecycle stale
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
/remove-lifecycle stale
/kind cleanup
What needs cleanup: [A clear and concise description of what needs to be cleaned up.]
Currently, the same logic is duplicated in both the template and non-template webhooks for AzureManaged* resources:
https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/2522297040bad726d43547531da05d012368f053/api/v1beta1/azuremanagedcontrolplanetemplate_default.go#L26 https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/2522297040bad726d43547531da05d012368f053/api/v1beta1/azuremanagedcontrolplane_webhook.go#L79
Describe the solution you'd like
The webhooks for AzureManaged* resources should follow the same pattern as the self-managed cluster types to avoid duplication.
Anything else you would like to add: [Miscellaneous information that will assist in solving the issue.]