kubernetes-sigs / cluster-api-provider-azure

Cluster API implementation for Microsoft Azure
https://capz.sigs.k8s.io/
Apache License 2.0
293 stars 422 forks source link

set EXP_ASO_API=true for CI #4926

Closed jackfrancis closed 3 months ago

jackfrancis commented 3 months ago

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR sets the ASO AKS API feature flag to true for all CI flows. This way we get additional coverage and will know about any edge cases that exist in this feature more rapidly.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

TODOs:

Release note:

NONE
codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.19%. Comparing base (44aba04) to head (cab67d2). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4926 +/- ## ======================================= Coverage 62.19% 62.19% ======================================= Files 201 201 Lines 16878 16878 ======================================= Hits 10497 10497 Misses 5591 5591 Partials 790 790 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nojnhuh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/main/OWNERS)~~ [nojnhuh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 3 months ago

LGTM label has been added.

Git tree hash: 5a8df8e79b08dfb05e8254ce5a106f00b9e371e4

nojnhuh commented 3 months ago

/retest

nojnhuh commented 3 months ago

hit westeurope again :/

/retest