search

kubernetes-sigs / cluster-api-provider-azure

Cluster API implementation for Microsoft Azure
https://capz.sigs.k8s.io/
Apache License 2.0
287 stars 414 forks source link

use AZURE_WORKLOAD_ID var for prow #4939

Open nawazkh opened 6 days ago

nawazkh commented 6 days ago

What type of PR is this? /kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes # TBD

Special notes for your reviewer:

TODOs:

Release note:

`ensure-azcli.sh` will now log in using `AZURE_WORKLOAD_ID` if `AZURE_WORKLOAD_ID` is available in the env.
k8s-ci-robot commented 6 days ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

codecov[bot] commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.22%. Comparing base (aed86ce) to head (2f30394). Report is 12 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4939 +/- ## ========================================== + Coverage 62.19% 62.22% +0.03% ========================================== Files 201 201 Lines 16884 16886 +2 ========================================== + Hits 10501 10508 +7 + Misses 5592 5585 -7 - Partials 791 793 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

k8s-ci-robot commented 4 days ago

LGTM label has been added.

Git tree hash: 1ad89fce498c9d1e5d73f4822f4df9d3cc83499e

jackfrancis commented 4 days ago

/test ls

k8s-ci-robot commented 4 days ago

@jackfrancis: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-azure/pull/4939#issuecomment-2192178853): >/test ls Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
jackfrancis commented 4 days ago

/test pull-cluster-api-provider-azure-capi-e2e /test pull-cluster-api-provider-azure-conformance /test pull-cluster-api-provider-azure-conformance-custom-builds /test pull-cluster-api-provider-azure-conformance-dual-stack-with-ci-artifacts /test pull-cluster-api-provider-azure-conformance-ipv6-with-ci-artifacts /test pull-cluster-api-provider-azure-conformance-with-ci-artifacts /test pull-cluster-api-provider-azure-e2e-optional /test pull-cluster-api-provider-azure-e2e-workload-upgrade /test pull-cluster-api-provider-azure-windows-custom-builds /test pull-cluster-api-provider-azure-windows-with-ci-artifacts

mboersma commented 4 days ago

This isn't a bugfix per se, but still I think we may want to cherry-pick this change in order to test it through test-infra.

nawazkh commented 3 days ago

/test pull-cluster-api-provider-azure-e2e-optional

nawazkh commented 3 days ago

/test pull-cluster-api-provider-azure-windows-custom-builds

jsturtevant commented 3 days ago

If we switch https://github.com/kubernetes/test-infra/pull/32837 to a new optional PR job, we could test this PR against the actual configuration before merging.

k8s-ci-robot commented 2 days ago

LGTM label has been added.

Git tree hash: ff52a59acc6cb6966c58af9049ab50255c34469e

k8s-ci-robot commented 2 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/main/OWNERS)~~ [jackfrancis] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
nawazkh commented 2 days ago

/test ls

k8s-ci-robot commented 2 days ago

@nawazkh: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-azure/pull/4939#issuecomment-2197710858): >/test ls > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
nawazkh commented 2 days ago

holding this PR from merging to test the optional test run. /hold

nawazkh commented 2 days ago

/test pull-cluster-api-provider-azure-e2e-with-wi-optional

k8s-ci-robot commented 2 days ago

@nawazkh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-e2e-optional ebe591730d7780052ee893fba0a657d1aebf0c08 link false /test pull-cluster-api-provider-azure-e2e-optional
pull-cluster-api-provider-azure-windows-custom-builds ebe591730d7780052ee893fba0a657d1aebf0c08 link false /test pull-cluster-api-provider-azure-windows-custom-builds
pull-cluster-api-provider-azure-e2e 2f30394efd13de1632246b83e90a1395e58b21fb link true /test pull-cluster-api-provider-azure-e2e
pull-cluster-api-provider-azure-e2e-with-wi-optional 2f30394efd13de1632246b83e90a1395e58b21fb link false /test pull-cluster-api-provider-azure-e2e-with-wi-optional

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).