search

kubernetes-sigs / cluster-api-provider-azure

Cluster API implementation for Microsoft Azure
https://capz.sigs.k8s.io/
Apache License 2.0
293 stars 422 forks source link

allow managed clusters for ci-entrypoint #4946

Closed nojnhuh closed 3 months ago

nojnhuh commented 3 months ago

What type of PR is this? /kind feature

What this PR does / why we need it:

This PR makes it possible to use ci-entrypoint.sh for clusters representing AKS clusters and using the ASO API by making some small changes. I'll add more details inline.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

TODOs:

Release note:

NONE
codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 62.19%. Comparing base (52df930) to head (1191658). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4946 +/- ## ======================================= Coverage 62.18% 62.19% ======================================= Files 201 201 Lines 16884 16885 +1 ======================================= + Hits 10499 10501 +2 + Misses 5594 5592 -2 - Partials 791 792 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nojnhuh commented 3 months ago

/hold until I get some version of this to pass at https://github.com/kubernetes/autoscaler/pull/6975

nojnhuh commented 3 months ago

we have green! https://github.com/kubernetes/autoscaler/pull/6975

/hold cancel

k8s-ci-robot commented 3 months ago

LGTM label has been added.

Git tree hash: 8d08efd4fd938fadd19b629ccea33c781db42ee3

nojnhuh commented 3 months ago

/hold for https://github.com/kubernetes/autoscaler/pull/6975#issuecomment-2192175889

nojnhuh commented 3 months ago

/hold also for squash

nojnhuh commented 3 months ago

/hold for kubernetes/autoscaler#6975 (comment)

All green over there (for real), so this is ready for review again. Leaving the hold until I squash.

jackfrancis commented 3 months ago

/test pull-cluster-api-provider-azure-capi-e2e /test pull-cluster-api-provider-azure-conformance /test pull-cluster-api-provider-azure-conformance-custom-builds /test pull-cluster-api-provider-azure-conformance-dual-stack-with-ci-artifacts /test pull-cluster-api-provider-azure-conformance-ipv6-with-ci-artifacts /test pull-cluster-api-provider-azure-conformance-with-ci-artifacts /test pull-cluster-api-provider-azure-e2e-optional /test pull-cluster-api-provider-azure-e2e-workload-upgrade /test pull-cluster-api-provider-azure-windows-custom-builds /test pull-cluster-api-provider-azure-windows-with-ci-artifacts

willie-yao commented 3 months ago

/lgtm

k8s-ci-robot commented 3 months ago

LGTM label has been added.

Git tree hash: 58f6813a8cfe9665c315c4de972edfca2d10eda0

jackfrancis commented 3 months ago

/lgtm /approve

jackfrancis commented 3 months ago

after squash commits of course :)

k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/main/OWNERS)~~ [jackfrancis] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
nojnhuh commented 3 months ago

squashed! /hold cancel

nojnhuh commented 3 months ago

/retest

nojnhuh commented 3 months ago

/test pull-cluster-api-provider-azure-e2e-aks