search

kubernetes-sigs / cluster-api-provider-azure

Cluster API implementation for Microsoft Azure
https://capz.sigs.k8s.io/
Apache License 2.0
297 stars 428 forks source link

Control NodeDrainTimeout #5159

Open adrianbrasov opened 1 month ago

adrianbrasov commented 1 month ago

/kind feature

Could we get a handle to control NodeDrainTimeout from ASO/Azure Managed MachinePools ? CAPI has that exposed at MachinePool but it doesn't propagate to Azure ( using AzureManagedMachinePool as infra ref ) https://github.com/kubernetes-sigs/cluster-api/blob/9569cd60e39f2bef80a3a7b293b920cad4f052be/config/crd/bases/cluster.x-k8s.io_machinepools.yaml#L402

nojnhuh commented 1 month ago

I remember taking a quick look at this a couple weeks ago and got the impression that this might be something that CAPI should handle generically across all providers. Are you seeing the correct behavior for any other provider (even the CAPI Docker one)?

adrianbrasov commented 1 month ago

I haven't tested anything else, Azure is our only cloud provider