Have PR tests for newely created templates for MS Tenants

kubernetes-sigs / cluster-api-provider-azure

Cluster API implementation for Microsoft Azure

https://capz.sigs.k8s.io/

Apache License 2.0

297 stars 428 forks source link

Have PR tests for newely created templates for MS Tenants #5321

Closed nawazkh closed 2 days ago

nawazkh commented 2 days ago

PR https://github.com/kubernetes-sigs/cluster-api-provider-azure/pull/5315 updates cluster scope and AzureCluster webhooks with adding default private IP config to the APIServerILB. Ideally we would want to have a test to support these changes.

This issue is to track

[ ] Create an optional job at K8s-test-infra to test APIServer ILB changes.
[ ] Create an e2e test at runs the new APIServerILB templates
- [ ] Create APIServerILB tempalates for prow/ci

nawazkh commented 2 days ago

redundant issue. Closing. Tasks shifted to the parent issue itself. /close.

nawazkh commented 2 days ago

/close

k8s-ci-robot commented 2 days ago

@nawazkh: Closing this issue.

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-azure/issues/5321#issuecomment-2518758311): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.