Closed hrak closed 1 year ago
Name | Link |
---|---|
Latest commit | e268a87f422d1945f9a9a2ed130b8c75166e170c |
Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-cluster-api-cloudstack/deploys/64ef250fe3411300085f094a |
Deploy Preview | https://deploy-preview-306--kubernetes-sigs-cluster-api-cloudstack.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Hi @hrak. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: chrisdoherty4, hrak
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/lgtm
/ok-to-test
Issue #, if available:
Description of changes:
Replace custom predicate functions with CAPI util/predicates functions in the CloudStackCluster and CloudStackMachine controller
Testing performed:
make test
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.