Fixup make generate-conversion

vishesh92 commented 4 months ago

Issue #, if available:

Description of changes: While running make generate-conversion, it returns a warning

E0530 15:46:54.126216  477229 conversion.go:756] Warning: could not find nor generate a final Conversion function for sigs.k8s.io/cluster-api-provider-cloudstack/api/v1beta3.CloudStackFailureDomainSpec -> ./api/v1beta2.CloudStackFailureDomainSpec
E0530 15:46:54.126252  477229 conversion.go:757]   the following fields need manual conversion:
E0530 15:46:54.126256  477229 conversion.go:759]       - Project

And the build fails with the below error:

api/v1beta2/zz_generated.conversion.go:147:10: undefined: Convert_v1beta3_CloudStackFailureDomainSpec_To_v1beta2_CloudStackFailureDomainSpec
api/v1beta2/zz_generated.conversion.go:574:14: undefined: Convert_v1beta3_CloudStackFailureDomainSpec_To_v1beta2_CloudStackFailureDomainSpec
api/v1beta2/zz_generated.conversion.go:630:12: undefined: Convert_v1beta3_CloudStackFailureDomainSpec_To_v1beta2_CloudStackFailureDomainSpec

Testing performed:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

netlify[bot] commented 4 months ago

Deploy Preview for kubernetes-sigs-cluster-api-cloudstack ready!

Name	Link
Latest commit	21a7c6543d90a1535f0f719e991054bfee4d8ce7
Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-cloudstack/deploys/66585311a281d000089467fa
Deploy Preview	https://deploy-preview-360--kubernetes-sigs-cluster-api-cloudstack.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

blueorangutan commented 4 months ago

Test Results : (tid-455) Environment: kvm Rocky8(x3), Advanced Networking with Management Server Rocky8 Kubernetes Version: v1.27.2 Kubernetes Version upgrade from: v1.26.5 Kubernetes Version upgrade to: v1.27.2 CloudStack Version: 4.19 Template: ubuntu-2004-kube E2E Test Run Logs: https://github.com/blueorangutan/capc-prs/releases/download/capc-pr-ci-cd/capc-e2e-artifacts-pr360-sl-455.zip


Summarizing 4 Failures:
 [FAIL] When testing Kubernetes version upgrades [It] Should successfully upgrade kubernetes versions when there is a change in relevant fields
 /root/go/pkg/mod/sigs.k8s.io/cluster-api/test@v1.4.8/framework/cluster_helpers.go:144
 [FAIL] When testing app deployment to the workload cluster [TC1][PR-Blocking] [It] Should be able to download an HTML from the app deployed to the workload cluster
 /jenkins/workspace/capc-e2e-new/test/e2e/deploy_app.go:111
 [FAIL] When testing app deployment to the workload cluster with slow network [ToxiProxy] [It] Should be able to download an HTML from the app deployed to the workload cluster
 /jenkins/workspace/capc-e2e-new/test/e2e/deploy_app_toxi.go:135
 [FAIL] When testing project [AfterEach] Should create a cluster in a project
 /jenkins/workspace/capc-e2e-new/test/e2e/project.go:103

Ran 29 of 30 Specs in 9796.191 seconds
FAIL! -- 25 Passed | 4 Failed | 0 Pending | 1 Skipped
--- FAIL: TestE2E (9796.19s)
FAIL

rohityadavcloud commented 4 months ago

/approve /lgtm

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rohityadavcloud, vishesh92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-cloudstack/blob/main/OWNERS)~~ [rohityadavcloud,vishesh92] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

kubernetes-sigs / cluster-api-provider-cloudstack