kubernetes-sigs / cluster-api-provider-gcp

The GCP provider implementation for Cluster API
Apache License 2.0
178 stars 194 forks source link

Nil pointer dereference, on an invalid spec #1187

Open mjnovice opened 5 months ago

mjnovice commented 5 months ago

/kind bug

What steps did you take and what happened: [A clear and concise description of what the bug is.] I created a GCPManagedCluster without the network field and the controller crashed.

What did you expect to happen: The controller shouldn't crash

https://github.com/kubernetes-sigs/cluster-api-provider-gcp/blob/main/cloud/services/container/clusters/reconcile.go#L256

Anything else you would like to add: [Miscellaneous information that will assist in solving the issue.]

Environment:

k8s-triage-robot commented 2 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

tasdikrahman commented 1 month ago

/assign

k8s-triage-robot commented 3 weeks ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten