search

kubernetes-sigs / cluster-api-provider-gcp

The GCP provider implementation for Cluster API
Apache License 2.0
199 stars 203 forks source link

chore: support registry and tag overrides in makefile #1367

Closed salasberryfin closed 1 week ago

salasberryfin commented 1 week ago

/kind cleanup

What this PR does / why we need it:

This change adds support for STAGING_REGISTRY/PROD_REGISTRY and RELEASE_TAG overrides in the Makefile. The current configuration does not allow setting a different value for these parameters via environment variables. This is a limitation in, for example, an air-gapped environment where a user may want to create their own release of the provider and reference an image stored in a custom registry.

It should not affect any existing use cases as the default value is unchanged.

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

TODOs:

Release note:

NONE
netlify[bot] commented 1 week ago

Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!

Name Link
Latest commit 4148de1b74b66014ece9ad92b92dac6dfc4356e8
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-gcp/deploys/673470189082980008d35338
Deploy Preview https://deploy-preview-1367--kubernetes-sigs-cluster-api-gcp.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

furkatgofurov7 commented 1 week ago

/lgtm

furkatgofurov7 commented 1 week ago

@cpanato @richardcase is there a way we could have a patch release after this PR is merged, since the last one was already 3 weeks ago? It would help us to fix a bug in our custom image-building workflow.

k8s-ci-robot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, salasberryfin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-gcp/blob/main/OWNERS)~~ [cpanato] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment