kubernetes-sigs / cluster-api-provider-gcp

The GCP provider implementation for Cluster API
Apache License 2.0
178 stars 194 forks source link

Support Application Default Credentials or Workload Identity when running in GCP #311

Open colinman opened 4 years ago

colinman commented 4 years ago

/kind feature

Describe the solution you'd like

Exporting service account credentials and storing in K8S secret store introduces an unnecessary secret and potential point of compromise if the cluster API provider is running inside GCP.

In this case, the provider should first look for Application Default Credentials or use workload identity before requiring service account credential keys.

fejta-bot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot commented 3 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten

detiber commented 3 years ago

/lifecycle frozen /help

k8s-ci-robot commented 3 years ago

@detiber: This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-gcp/issues/311): >/lifecycle frozen >/help Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
prksu commented 3 years ago

/assign

itspngu commented 1 year ago

This would be really useful, at least if initially Application Default Credentials were supported - use of Workload Identity from within a Management cluster running on GKE could be built on top of that. @prksu are you currently still working on this? I'd like to see if I can contribute to this if needed.