Update deletion logic for VPC subnet, load balancer and PowerVS service instance

Amulyam24 commented 4 months ago

What this PR does / why we need it: This PR addresses the following

When a PowerVS service instance creation fails, deletion of it will never go through as fetching DHCP servers will give an error as service instance doesn't exist. Add a check to verify it before proceeding for deletion

"Reconciler error" err="failed to delete Power VS service instance: failed to fetch networks in the PowerVS service instance: failed to Get all DHCP servers: [GET /pcloud/v1/cloud-instances/{cloud_instance_id}/services/dhcp][403] pcloudDhcpGetallForbidden  &{Code:403 Description: Error: Message:unable to find cloud instance id for service instance 05d6bd74-b240-4544-a889-a6c18c52ade4: cloud-instance (name) 05d6bd74-b240-4544-a889-a6c18c52ade4 not found}" controller="ibmpowervscluster" controllerGroup="infrastructure.cluster.x-k8s.io" controllerKind="IBMPowerVSCluster"

In a scenario where a one among a list of VPC subnets or load balancers deletion fails, it will pause the deletion of others in the list. Don't return an error immediately and continue to delete them. Return the errors at the end.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #1764

Special notes for your reviewer:

/area provider/ibmcloud

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Update deletion logic for VPC subnet, load balancer and PowerVS service instance

netlify[bot] commented 4 months ago

Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name	Link
Latest commit	ef413e18344c461c988a099754db3a6ddf0e6b7e
Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/6646168390257c0008459f8a
Deploy Preview	https://deploy-preview-1776--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dharaneeshvrd commented 4 months ago

/lgtm

Amulyam24 commented 4 months ago

/cc @mkumatag

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Amulyam24, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/blob/main/OWNERS)~~ [mkumatag] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

kubernetes-sigs / cluster-api-provider-ibmcloud