Closed damdo closed 1 month ago
Name | Link |
---|---|
Latest commit | f7703ec2fa4ad45d59ec1d7f44ced70283cd10e3 |
Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/664f283ce031bf00087b725c |
Deploy Preview | https://deploy-preview-1794--kubernetes-sigs-cluster-api-ibmcloud.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
/assign @mkumatag @Karthik-K-N @Amulyam24
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: damdo, mkumatag
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@mkumatag @Karthik-K-N Do we want to backport this to release-0.8 and release-0.7 ?
I think that would be better.
/cherrypick release-0.8
@mkumatag: new pull request created: #1796
/cherrypick release-0.7
@mkumatag: #1794 failed to apply on top of branch "release-0.7":
Applying: fix: remove whitespaces from metadata.yaml
Using index info to reconstruct a base tree...
M metadata.yaml
Falling back to patching base and 3-way merge...
Auto-merging metadata.yaml
CONFLICT (content): Merge conflict in metadata.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix: remove whitespaces from metadata.yaml
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
@mkumatag: #1794 failed to apply on top of branch "release-0.7":
my bad, I need to fix that manually!
Similar to this fix I opened last year: https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/pull/1441
this can trip up parsers that read the metadata file.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged): Fixes #Special notes for your reviewer:
/area provider/ibmcloud
Release note: