kubernetes-sigs / cluster-api-provider-ibmcloud

Cluster API Provider for IBM Cloud
https://cluster-api-ibmcloud.sigs.k8s.io
Apache License 2.0
60 stars 76 forks source link

fix: remove whitespaces from metadata.yaml #1794

Closed damdo closed 1 month ago

damdo commented 1 month ago

Similar to this fix I opened last year: https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/pull/1441

this can trip up parsers that read the metadata file.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

fix: remove trailing whitespaces from metadata.yaml
netlify[bot] commented 1 month ago

Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
Latest commit f7703ec2fa4ad45d59ec1d7f44ced70283cd10e3
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/664f283ce031bf00087b725c
Deploy Preview https://deploy-preview-1794--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

damdo commented 1 month ago

/assign @mkumatag @Karthik-K-N @Amulyam24

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/blob/main/OWNERS)~~ [mkumatag] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
damdo commented 1 month ago

@mkumatag @Karthik-K-N Do we want to backport this to release-0.8 and release-0.7 ?

Karthik-K-N commented 1 month ago

I think that would be better.

mkumatag commented 1 month ago

/cherrypick release-0.8

k8s-infra-cherrypick-robot commented 1 month ago

@mkumatag: new pull request created: #1796

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/pull/1794#issuecomment-2128615626): >/cherrypick release-0.8 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
mkumatag commented 1 month ago

/cherrypick release-0.7

k8s-infra-cherrypick-robot commented 1 month ago

@mkumatag: #1794 failed to apply on top of branch "release-0.7":

Applying: fix: remove whitespaces from metadata.yaml
Using index info to reconstruct a base tree...
M   metadata.yaml
Falling back to patching base and 3-way merge...
Auto-merging metadata.yaml
CONFLICT (content): Merge conflict in metadata.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix: remove whitespaces from metadata.yaml
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/pull/1794#issuecomment-2128617085): >/cherrypick release-0.7 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
mkumatag commented 1 month ago

@mkumatag: #1794 failed to apply on top of branch "release-0.7":

my bad, I need to fix that manually!