search

kubernetes-sigs / cluster-api-provider-ibmcloud

Cluster API Provider for IBM Cloud
https://cluster-api-ibmcloud.sigs.k8s.io
Apache License 2.0
62 stars 79 forks source link

Update kube-vip spec in cluster templates to adopt k8s 1.29 #1798

Closed Amulyam24 closed 4 months ago

Amulyam24 commented 4 months ago

What this PR does / why we need it: kube-vip has issues when being used with k8s 1.29. This PR fixes them by

  1. From 1.29, a change has been made to kubeadm to provision a separate Kubeconfig file called super-admin.conf and reducing the admin.conf User's access to the permissions provided by the cluster-admin ClusterRole. It is to be noted that in a multi-cluster setup, the super-admin.conf is only created on the primary control plane node, which runs kubeadm init is failing because kube-vip deployment is hardcoded to use admin.conf but kube-vip requires elevated permissions to access the API server during cluster initialization, which are available only when using the super-admin.conf.
  2. From 1.29, hostAliases do not work as expected. Add a work around to mount the volumes to the kube-vip pod manifest.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #1792

Special notes for your reviewer:

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

Update kube-vip spec in cluster templates to adopt k8s 1.29
netlify[bot] commented 4 months ago

Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
Latest commit 4dd2ee8937810c4b29fde0bf6d57eab65e178f77
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/66503caaaf4f570008a27224
Deploy Preview https://deploy-preview-1798--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Prajyot-Parab commented 4 months ago

/lgtm awaiting approval of @mkumatag

k8s-ci-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Amulyam24, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/blob/main/OWNERS)~~ [mkumatag] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Amulyam24 commented 4 months ago

@mkumatag, should we back port this to release-0.8 branch?

mkumatag commented 4 months ago

@mkumatag, should we back port this to release-0.8 branch?

I feel not required, we aren't testing that branch aggressively!