Enhance deletion logic

[Amulyam24]

/kind feature /area provider/ibmcloud

Describe the solution you'd like We are currently fetching the resource and checking against a text phrase if it is successfully deleted(eg: VPC), leverage using http status codes instead. This is applicable to

• [ ] VPC resources(VPC, load balancer, subnet, security groups)
• [ ] Transit gateway

Anything else you would like to add: [Miscellaneous information that will assist in solving the issue.]

[Amulyam24]

/good-first-issue

[k8s-ci-robot]

@Amulyam24: This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/issues/1805): >/good-first-issue Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

[dharaneeshvrd]

/assign

[dharaneeshvrd]

Planning to fix couple of issues along with this

1. Observed that when DHCP server deletion throws error it did nt get logged and powervs deletion is also stuck with waiting for dhcp server to get deleted.
2. Usually powervs instance deletion will not get deleted in first attempt, need to retry after sometime. So need to add requeue logic to Retrying the delete, until it succeeds.

[dharaneeshvrd]

@Amulyam24 Is it ok to address the above issues also in this issue, or is it better to create a separate issue? wdyt?

[Amulyam24]

Sure, we can handle it as a part of this issue with detailed description and separate commits in PR if needed as it comes under the umbrella of enhancing the deletion logic.

2. Usually powervs instance deletion will not get deleted in first attempt, need to retry after sometime. So need to add requeue logic to Retrying the delete, until it succeeds.

For this, I recently added a change in the PR. If additional checks are required, feel free to add the enhancements in your PR.