Open Karthik-K-N opened 4 months ago
~Will take up adding UT for cloud/scope/powervs_cluster.go
~ Currently not assigning to myself, feel free to pick up UT for powervs_cluster.go
We will add UT for ibmpowervscluster_controller.go file once we finalize and fix the issue https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/issues/1837 as it involves some code refactoring.
If contributing to this issue, Please do comment here with function name to avoid multiple folks working on same thing.
I am working on adding UT for ReconcileNetwork, ReconcileVPC and ReconcileVPCSubnets function
/reopen
@Karthik-K-N: Reopened this issue.
Picking up UT for the ReconcileLoadBalancers function
Picking up UT for ReconcileVPCSecurityGroups function
/kind feature /area provider/ibmcloud
Describe the solution you'd like [A clear and concise description of what you want to happen.]
Recently we added lots of functionality but haven't added any corresponding UT's to it. Its time to add unit test cases and overall goal is to reach 80% of test coverage.
As a non-goal during the time of adding UT if we find any redundant or unwanted or code duplication, a separate PR needs to be submitted to optimize the code.
Anything else you would like to add: [Miscellaneous information that will assist in solving the issue.]
Instructions for running individual tests on VS Code
Get kubebuilder asset path
Create settings.json file with kubebuilder asset path
$ cd cluster-api-provider-ibmcloud/.vscode $ make test-cover