kubernetes-sigs / cluster-api-provider-ibmcloud

Cluster API Provider for IBM Cloud
https://cluster-api-ibmcloud.sigs.k8s.io
Apache License 2.0
60 stars 76 forks source link

Derive VPC zones from VPC region instead of PowerVS region. #1819

Closed kishen-v closed 1 month ago

kishen-v commented 1 month ago

What this PR does / why we need it: This PR contains changes to derive the VPC zone from the VPC region, compared to the zone derived from PowerVS region. This mitigates errors/conflicts arising where the VPC zone is different from the PowerVS zone, causing a mismatch in the CIDR.

Tests: The change has been tested where the compute infrastructure is provisioned in jp-osa, while the VPC subnet infrastructure was provisioned in jp-tok. The was available for use post completion of deployment.

Pasted Graphic 2

A similar exercise was done to provision both Compute and VPC subnet in jp-osa.

Which issue(s) this PR fixes : Fixes #1817

Special notes for your reviewer: Please let me know if there are other scenarios to be covered before the changes can be merged to main.

/area provider/ibmcloud

Release note:

Derive VPC zones from VPC region instead of PowerVS region.
k8s-ci-robot commented 1 month ago

Hi @kishen-v. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
netlify[bot] commented 1 month ago

Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
Latest commit b2744d6cd711be93312ad4b81113a09482473ea7
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/66597d8b2054b3000867a91a
Deploy Preview https://deploy-preview-1819--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

kishen-v commented 1 month ago

cc : @Karthik-K-N @Amulyam24

Amulyam24 commented 1 month ago

/ok-to-test

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishen-v, Prajyot-Parab

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/blob/main/OWNERS)~~ [Prajyot-Parab] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment