search

kubernetes-sigs / cluster-api-provider-ibmcloud

Cluster API Provider for IBM Cloud
https://cluster-api-ibmcloud.sigs.k8s.io
Apache License 2.0
62 stars 84 forks source link

Refactor infra creation to improve the overall infra setup time #1869

Closed dharaneeshvrd closed 3 months ago

dharaneeshvrd commented 5 months ago

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #1837

Special notes for your reviewer:

With the changes, infra creation takes around ~8 mins. Most time taking resource is DHCP server VM.

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

netlify[bot] commented 5 months ago

Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
Latest commit fe3834537733baf4390be7096d8adfceca89c9a5
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-ibmcloud/deploys/66c8229d701b310008c1b317
Deploy Preview https://deploy-preview-1869--kubernetes-sigs-cluster-api-ibmcloud.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dharaneeshvrd commented 4 months ago

@Karthik-K-N

Whats the time difference between old vs new approach?

Currently it's taking around 15 mins and with these changes it is taking around 8 to 9 mins.

mkumatag commented 3 months ago

@dharaneeshvrd as per the discussion, lets get the early testing done with this PR to ensure it is working fine

mkumatag commented 3 months ago

@dharaneeshvrd as per the discussion, lets get the early testing done with this PR to ensure it is working fine

Any update on this?

/cc @Karthik-K-N

please take a look and give lgtm if no more comments

dharaneeshvrd commented 3 months ago

@mkumatag

Any update on this?

I have tested personally and Ashwin Hendre also able to test this and reported the improvement of 12% overall cluster setup time.

k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dharaneeshvrd, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud/blob/main/OWNERS)~~ [mkumatag] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment